Skip to content

Commit

Permalink
Add upper ranges to metadata.json to appease lint
Browse files Browse the repository at this point in the history
  • Loading branch information
oranenj authored and bastelfreak committed Jul 19, 2017
1 parent cb74f93 commit 8caeeef
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions metadata.json
Expand Up @@ -92,19 +92,19 @@
"dependencies": [
{
"name": "puppetlabs/stdlib",
"version_requirement": ">= 4.6.0"
"version_requirement": ">= 4.6.0 < 5.0.0"
},
{
"name": "puppetlabs/concat",
"version_requirement": ">= 1.2.5"
"version_requirement": ">= 1.2.5 < 5.0.0"
},
{
"name": "stahnma-epel",
"version_requirement": ">= 1.2.2"
"version_requirement": ">= 1.2.2 < 2.0.0"
},
{
"name": "puppetlabs-apt",
"version_requirement": ">= 2.2.0"
"version_requirement": ">= 2.2.0 < 3.0.0"

This comment has been minimized.

Copy link
@booo

booo Aug 8, 2017

Do you think we can raise this to "< 4.0.0" or something?

https://forge.puppet.com/puppetlabs/apt

This comment has been minimized.

Copy link
@bastelfreak

bastelfreak Aug 8, 2017

Member

yes we can. Do you want to provide a PR for this?

This comment has been minimized.

Copy link
@booo

booo Aug 8, 2017

I wonder if this should actually be a soft dependency:

https://docs.puppet.com/puppet/latest/style_guide.html#dependencies

The nginx module change the dependency to a soft dependency mentioned in the RAEDME:

voxpupuli/puppet-nginx#1086

I think this affects the epel module as well.

}
]
}

0 comments on commit 8caeeef

Please sign in to comment.