Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iptables module needs to support multiple chains by same name #237

Closed
jpds-zz opened this issue Feb 8, 2015 · 2 comments
Closed

iptables module needs to support multiple chains by same name #237

jpds-zz opened this issue Feb 8, 2015 · 2 comments

Comments

@jpds-zz
Copy link
Contributor

jpds-zz commented Feb 8, 2015

I would like to be able to do:

class { 'collectd::plugin::iptables':
  chains  => {
    'filter' => 'INPUT',
    'filter' => 'OUTPUT',
  },
}

In my config, but it only writes the OUTPUT(/last) option.

@txaj
Copy link

txaj commented Feb 10, 2015

when I read the manifests I'd guess this should be already the case. can someone reproduce this ?

@jonnangle
Copy link
Contributor

I see this problem too; chains is a hash and so the keys collide if you try to use this syntax.

An alternative would be:

class { 'collectd::plugin::iptables':
  chains  => {
    'filter' => ['INPUT','OUTPUT'],
  },
}

I've created a PR #302 which implements this.

@blkperl blkperl closed this as completed in 6baf790 Aug 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants