Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow iptables chains parameter to be an array (fix #237) #302

Merged
merged 2 commits into from
Aug 6, 2015

Conversation

jonnangle
Copy link
Contributor

When using the iptables plugin, this allows you to provide more than one chain for each table by passing an array as the hash value. For example:

class { 'collectd::plugin::iptables':
  chains  => {
    'filter' => ['INPUT','OUTPUT'],
  },
}

Chain <%= table %> <%= chain %>
<% end -%>
<% end
end -%>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that missing a <% why is Travis not failing?

Edit: Oh you have two ends in the same ruby block. Please don't do that, its confusing and could introduce a bug if someone edits this file in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, now fixed!

@blkperl
Copy link
Member

blkperl commented Aug 6, 2015

Thanks for the contribution!

blkperl added a commit that referenced this pull request Aug 6, 2015
Allow iptables chains parameter to be an array (fix #237)
@blkperl blkperl merged commit 6baf790 into voxpupuli:master Aug 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants