Error with Plugin "Load" with collectd-5.9 and RHEL-8

[dusharu]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 5.5.17
• Ruby:
• Distribution: Red Hat Enterprise Linux release 8.1 (Ootpa)
• Module version: puppet-collectd (v10.1.0)
• Collectd: 5.9.0

How to reproduce (e.g Puppet code you use)

class { 'collectd::plugin::load': }

What are you seeing

Try test config after puppet run.

# collectd -T
Error: Parsing the config file failed!

What behaviour did you expect instead

Disable template load.conf.erb for collectd 5.9
https://github.com/voxpupuli/puppet-collectd/blob/master/templates/plugin/load.conf.erb

It works after comment <Plugin load> sections in config.

# vim /etc/collectd.d/10-load.conf
###### /etc/collectd.d/10-load.conf ###### 
# Generated by Puppet
<LoadPlugin load>
  Globals false
</LoadPlugin>

#<Plugin load>
#  ReportRelative false
#</Plugin>
###### /etc/collectd.d/10-load.conf ###### 

# collectd -T
# systemctl restart collectd
# systemctl status collectd |grep ac
   Active: active (running) since Thu 2019-12-26 16:12:41 MSK; 6s ago

Output log

# puppet agent -t
Info: Using configured environment 'develop'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Info: Applying configuration version '1577365409'
Info: Computing checksum on file /etc/collectd.d/.10-load.conf.swp
Info: /Stage[main]/Collectd::Config/File[/etc/collectd.d/.10-load.conf.swp]: Filebucketed /etc/collectd.d/.10-load.conf.swp to puppet with sum fc107359032900b1f7da7d76b871eeb8
Notice: /Stage[main]/Collectd::Config/File[/etc/collectd.d/.10-load.conf.swp]/ensure: removed (corrective)
Info: Class[Collectd::Config]: Scheduling refresh of Class[Collectd::Service]
Info: Class[Collectd::Service]: Scheduling refresh of Service[collectd]
Notice: /Stage[main]/Qas/Exec[vastool_timesync]/returns: executed successfully (corrective)
Notice: /Stage[main]/Collectd::Plugin::Load/Collectd::Plugin[load]/File[load.load]/content: 
--- /etc/collectd.d/10-load.conf        2019-12-26 15:35:50.519697413 +0300
+++ /tmp/puppet-file20191226-32658-5tkooe       2019-12-26 16:03:40.930111466 +0300
@@ -3,6 +3,7 @@
   Globals false
 </LoadPlugin>
 
-#<Plugin load>
-#  ReportRelative false
-#</Plugin>
+<Plugin load>
+  ReportRelative false
+</Plugin>
+

Info: Computing checksum on file /etc/collectd.d/10-load.conf
Info: /Stage[main]/Collectd::Plugin::Load/Collectd::Plugin[load]/File[load.load]: Filebucketed /etc/collectd.d/10-load.conf to puppet with sum 9eecb76e10471d29c19643e62b8c98f2
Notice: /Stage[main]/Collectd::Plugin::Load/Collectd::Plugin[load]/File[load.load]/content: content changed '{md5}9eecb76e10471d29c19643e62b8c98f2' to '{md5}98cd4523a355f4ea6a49c381408380e3'
Notice: /Stage[main]/Collectd::Plugin::Load/Collectd::Plugin[load]/File[load.load]/mode: mode changed '0644' to '0640'
Notice: /Stage[main]/Collectd::Plugin::Load/Collectd::Plugin[load]/File[load.load]/seluser: seluser changed 'unconfined_u' to 'system_u'
Info: /Stage[main]/Collectd::Plugin::Load/Collectd::Plugin[load]/File[load.load]: Scheduling refresh of Service[collectd]
Info: /Stage[main]/Collectd::Plugin::Load/Collectd::Plugin[load]/File[load.load]: Scheduling refresh of Service[collectd]
Info: /Stage[main]/Collectd::Plugin::Load/Collectd::Plugin[load]/File[load.load]: Scheduling refresh of Service[collectd]
Error: /Stage[main]/Collectd::Service/Service[collectd]: Failed to call refresh: Systemd restart for collectd failed!
journalctl log for collectd:
-- Logs begin at Wed 2019-12-04 18:04:43 MSK, end at Thu 2019-12-26 16:03:41 MSK. --
Dec 26 16:03:41  systemd[1]: Stopping Collectd statistics daemon...
Dec 26 16:03:41 systemd[1]: Stopped Collectd statistics daemon.
Dec 26 16:03:41 systemd[1]: Starting Collectd statistics daemon...
Dec 26 16:03:41 collectd[637]: plugin_load: plugin "syslog" successfully loaded.
Dec 26 16:03:41collectd[637]: network plugin: The `MaxPacketSize' must be between 1024 and 65535.
Dec 26 16:03:41 collectd[637]: Error: Parsing the config file failed!
Dec 26 16:03:41 systemd[1]: collectd.service: Main process exited, code=exited, status=1/FAILURE
Dec 26 16:03:41 systemd[1]: collectd.service: Failed with result 'exit-code'.
Dec 26 16:03:41 systemd[1]: Failed to start Collectd statistics daemon.

Error: /Stage[main]/Collectd::Service/Service[collectd]: Systemd restart for collectd failed!
journalctl log for collectd:
-- Logs begin at Wed 2019-12-04 18:04:43 MSK, end at Thu 2019-12-26 16:03:41 MSK. --
Dec 26 16:03:41systemd[1]: Stopping Collectd statistics daemon...
Dec 26 16:03:41 systemd[1]: Stopped Collectd statistics daemon.
Dec 26 16:03:41 systemd[1]: Starting Collectd statistics daemon...
Dec 26 16:03:41 collectd[637]: plugin_load: plugin "syslog" successfully loaded.
Dec 26 16:03:41 collectd[637]: network plugin: The `MaxPacketSize' must be between 1024 and 65535.
Dec 26 16:03:41collectd[637]: Error: Parsing the config file failed!
Dec 26 16:03:41 systemd[1]: collectd.service: Main process exited, code=exited, status=1/FAILURE
Dec 26 16:03:41systemd[1]: collectd.service: Failed with result 'exit-code'.
Dec 26 16:03:41systemd[1]: Failed to start Collectd statistics daemon.

Info: Class[Collectd]: Unscheduling all events on Class[Collectd]
Info: Stage[main]: Unscheduling all events on Stage[main]
Notice: Applied catalog in 7.51 seconds

Any additional information you'd like to impart

[cyberkov]

This issue is tracked on collectd/collectd#3180 as well. Unfortunately it'll take some time until it rolls in RHEL8 :(