Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept + in collectd_version Fact #1030

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Accept + in collectd_version Fact #1030

merged 1 commit into from
Oct 24, 2023

Conversation

quartsize
Copy link
Contributor

Pull Request (PR) description

The version string resulting from a make dist of collectd may contain a +, e.g. 5.12.0.167.g7c5ce9f+, from being run on a dirty working tree.

Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to also add a test where the version has a + to ensure that this doesn't break in the future.

The version string resulting from a `make dist` of collectd may contain
a +, e.g. 5.12.0.167.g7c5ce9f+, from being run on a dirty working tree.
@quartsize
Copy link
Contributor Author

Would be good to also add a test where the version has a + to ensure that this doesn't break in the future.

Added.

@kenyon kenyon merged commit a08b69f into voxpupuli:master Oct 24, 2023
32 checks passed
@bastelfreak bastelfreak added the enhancement New feature or request label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants