Adds Collectd CI Package repos #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petems
force-pushed
the
add_ci_pkg_repos
branch
2 times, most recently
from
51359d9
to
5147efa
Compare
igalic
suggested changes
Nov 29, 2016
| } | ||
| } | ||
| } | ||
| default: { |
There was a problem hiding this comment.
this whole class can be simplified to
$os_class = downcase($::operatingsystem)
if defined("::collectd::repo::${os_class}") {
include "::collectd::repo::$os_class"
} else {
notify{"You have asked to manage_repo on a ${::osfamily} family that doesn't have a repo specified: ${::operatingsystem}":}
}
petems
force-pushed
the
add_ci_pkg_repos
branch
2 times, most recently
from
613bd24
to
944eb8e
Compare
igalic
approved these changes
Nov 30, 2016
|
some (related) tests are failing: |
petems
force-pushed
the
add_ci_pkg_repos
branch
5 times, most recently
from
5e78f51
to
7d5d2c0
Compare
|
@petems See updates to your branch for fixes to Rubucop fails and added 5.7 support. |
|
@jamtur01 Much appreciated! 👍 |
|
@igalic The test failures seem to be a) network issue and b) deprecation notice from dependency. Not sure either are related to this PR. Any thoughts? |
petems
force-pushed
the
add_ci_pkg_repos
branch
from
d08d7a4
to
785a8ea
Compare
* Allows installation of 5.6 version of Collectd, 5.7 or RC (current master branch) * Refactor repo management behaviour into it's own classes * Add parameter to specify version from bleeding edge repos from CI
petems
force-pushed
the
add_ci_pkg_repos
branch
from
785a8ea
to
895ca35
Compare
bastelfreak
requested changes
Dec 19, 2016
| } else { | ||
| if $::operatingsystem == 'Debian' { | ||
| warning('Youre trying to use the Ubuntu PPA on a Debian Server, which may cause errors') | ||
| warning('We recomend you use the $ci_package_repo parameter if you with to use an upstream repo on Debian') |
There was a problem hiding this comment.
" if you with to " sounds like a typo?
bastelfreak
approved these changes
Dec 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #578