Changes RedHat repo to use the EPEL module #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petems
force-pushed
the
change_to_epel_module
branch
from
7fc97c5
to
6adb075
Compare
|
+1 |
|
@petems I know this is simply following the pattern, but this is a soft dependency, no? |
vinzent
reviewed
Jan 18, 2017
|
I don't like the use of |
|
I don't like the use of ```require```. Can we avoid it?
Perhaps also consider ```$repo_class``` as a variable
Or just make it completly optional by requiring users to include a repo subclass if they require it? Somewhat Roles/profiles style.
|
|
I was trying to match the original behaviour as much as possible, which is to default to have the upstream class enabled. |
petems
force-pushed
the
change_to_epel_module
branch
from
6adb075
to
5596b86
Compare
|
@petems can you rebase? Then rubocop should be happy again. |
petems
force-pushed
the
change_to_epel_module
branch
from
5596b86
to
c7ba015
Compare
|
@bastelfreak Done! 👍 |
|
hrm damn, the recently merged cuda plugin uses the yum module as well. https://travis-ci.org/voxpupuli/puppet-collectd/jobs/200865588#L3647-L3654 |
* Yum::Install to install the RPM is a bit more flakey * EPEL module is pretty ubiquitous, not that big of a deal to add it
petems
force-pushed
the
change_to_epel_module
branch
from
c7ba015
to
93d6f3e
Compare
|
@bastelfreak Ah, fixed. That's repeated code that could probably be DRY-ed up, but I'll leave that to a seperate PR! 👍 |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing the RPM is clunky and 99% of people use the EPEL module