BREAKING: Fix and simplify write_network plugin definition #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christophe Vanlancker <christophe.vanlancker@inuits.eu>
carroarmato0
force-pushed
the
fix_write_network_hash
branch
from
cebe435
to
d1ea219
Compare
|
Hmm, looks like the Rubocop test is complaining. But not sure if my changes have influence on that. I just let it be? |
vinzent
requested changes
Feb 10, 2017
There was a problem hiding this comment.
this introduces a breaking change.
I think the intention was to use create_resources but then only the first entry was used. nowadays one could use puppet4 each loops.
With only one entry it IMHO doesn't make much sens because you can use collectd::plugin::network::server directly without using another wrapper.
regarding the rubocop test error maybe you need a rebase?
vinzent
added
needs-rebase
needs-work
vinzent
changed the title
|
Hi @carroarmato0 , thanks for the PR. Can you please rebase it against latest master? |
|
Hi @carroarmato0, I'm going to close this PR due to inactivity. Feel free to reopen it if you're still interested in it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin expects a hash to be passed, yet, only the first element is being used.
Means that a lot of redundancy can be removed.
Also fixed an issue with passing the wrong value to ::collectd::plugin::network which expects servers instead of server.
Signed-off-by: Christophe Vanlancker christophe.vanlancker@inuits.eu