Tag collectd's concat resources #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if there's a suitable spec test to use to test the ordering here, or maybe @saz can you test it for us? |
bastelfreak
approved these changes
Jan 11, 2017
|
I don't think this is working as expected, because this tag should be set on all concat resources in this module. Or is there some magic which adds a tag and I'm just missing the knowledge? :-) |
|
Puppet should magically add tags for every class/subclass a resource is in
automatically (collectd, collectd::sub if declared in collectd::sub).
Should :)
--
Rob Nelson
|
|
Cool, didn't know that. I'll try it tomorrow and let you know.
|
juniorsysadmin
approved these changes
Jan 11, 2017
|
Working as expected. Thanks! |
|
You're welcome and thanks for testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #624