Add class ovs_events plugin #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paramite
force-pushed
the
feature/ovs_events
branch
3 times, most recently
from
276ceda
to
fffe997
Compare
|
@bastelfreak: Can this be merged now please, when all checks are passing? |
|
@alexjfisher This one is similar, can you please check it too? Thanks in advance. |
alexjfisher
reviewed
Jan 19, 2018
templates/plugin/ovs_events.conf.erb
Outdated
| <%- if @interfaces %> | ||
| Interfaces "<%= @interfaces.join('" "') %>" | ||
| <%- end -%> | ||
| <%- if defined?(@send_notification) %> |
There was a problem hiding this comment.
I'd have gone with unless @send_notification.null?, but I guess if defined? also works.
alexjfisher
reviewed
Jan 19, 2018
manifests/plugin/ovs_events.pp
Outdated
| Optional[String] $address = undef, | ||
| Optional[Boolean] $dispatch = undef, | ||
| String $ensure = 'present', | ||
| Optional[Array] $interfaces = undef, |
There was a problem hiding this comment.
Maybe better to use Optional[Array[1]]? or default to an empty array and adjust the template.
alexjfisher
reviewed
Jan 19, 2018
manifests/plugin/ovs_events.pp
Outdated
| # by the plugin | ||
| # | ||
| class collectd::plugin::ovs_events ( | ||
| Optional[String] $address = undef, |
There was a problem hiding this comment.
Stdlib::Host is available in recent stdlib.
alexjfisher
approved these changes
Jan 19, 2018
|
@paramite LGTM. I've left a couple of random comments, but these are very minor and subjective. |
paramite
force-pushed
the
feature/ovs_events
branch
from
fffe997
to
257c172
Compare
paramite
force-pushed
the
feature/ovs_events
branch
from
257c172
to
e939787
Compare
|
@alexjfisher So as test suite discovered, "@send_notification.null?" does not work. I've added the other suggested changes. |
This patch is adding support for ovs_events plugin configuration and installation.
paramite
force-pushed
the
feature/ovs_events
branch
from
e939787
to
76c99fc
Compare
bastelfreak
reviewed
Mar 6, 2018
| # by the plugin | ||
| # | ||
| class collectd::plugin::ovs_events ( | ||
| Optional[Stdlib::Host] $address = undef, |
|
Thanks for the PR @paramite ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is adding support for ovs_events plugin configuration and installation.