apache: sync options and add tests #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
May 25, 2018
| content: content_instance_file, | ||
| path: "#{options[:plugin_conf_dir]}/25-apache-instance-site2.conf" | ||
| ) | ||
| end |
There was a problem hiding this comment.
could you add another test to verify that it compiles with all dependencies?
There was a problem hiding this comment.
I have added check that required classes are included, is that enough ?
There was a problem hiding this comment.
please add a is_expected.to compile.with_all_deps
bastelfreak
reviewed
May 25, 2018
|
|
||
| it 'Will not manage collectd-apache' do | ||
| is_expected.not_to contain_package('collectd-apache').with(ensure: 'present', | ||
| name: 'collectd-apache') |
bastelfreak
added
enhancement
|
Hi @sileht, thanks for the PR. Can you take a look at the inline comments and the failing travis job? |
sileht
force-pushed
the
sileht/apache-plugin
branch
3 times, most recently
from
cf1287a
to
01f9211
Compare
|
Any update ? |
This change adds test coverage for the apache plugins. And two missing options SSLCiphers and Timeout.
sileht
force-pushed
the
sileht/apache-plugin
branch
from
01f9211
to
8c189e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apache: sync options and add tests
This change adds test coverage for the apache plugins.
And two missing options SSLCiphers and Timeout.