write_riemann plugin fixes and enhancements #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While here, fix a few inconsistencies in the test suite.
Only output configuration for provided parameters, let the default values be inferred by collectd itself and not the module.
smortex
changed the title
- Do not prepent parameter names with "riemann_" (riemann_host -> host; riemann_port -> port) to be consistent with other parameters; - Only allow to pass ttl_factor as a Float (as per the documentation); - Only allow to pass port as an Integer (as per the documentation).
bastelfreak
reviewed
Jul 14, 2018
| Enum['present', 'absent'] $ensure = 'present', | ||
| Boolean $manage_package = $collectd::manage_package, | ||
| Array[String[1]] $tags = [], | ||
| Hash[String[1],String[1]] $attributes = {}, |
bastelfreak
reviewed
Jul 14, 2018
| @@ -28,6 +19,6 @@ | |||
|
|
|||
| collectd::plugin { 'write_riemann': | |||
| ensure => $ensure, | |||
| content => template('collectd/plugin/write_riemann.conf.erb'), | |||
| content => epp('collectd/plugin/write_riemann.conf.epp'), | |||
|
Thanks for the awesome work @smortex ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The
write_riemannplugin has some problems that are fixed by this problem report:riemann_hostandriemann_portwhere renamed tohostandport);protocolsandstore_rateshad wrong default value. Do not set default values to the plugin parameters, and only output those that where explicitly set by the end-user. This allows collectd to use the default value if a parameter was not set by the user).This Pull Request (PR) fixes the following issues
n/a
Because this breaks the API in an unavoidable way, it might be interesting to merge this before #828.