Persist the interval in the conf file as a number #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passing it as a string the plugin will basically ignore the
setting and write the following to the log file:
cf_util_get_cdtime:
The Interval option requires exactly one numeric argument.
Without this patch it's not possible to declare different databases with
different query interval.
|
This parameter is not currently tested but a good time to add it. |
|
Would be good to convert this particular plugin to puppet 4 types as well. The whole module expects puppet 4. |
|
I've added an extra assert to an existing test to make sure that the value ends up in the configuration file properly formatted. |
|
I'm happy with other changes eg. to add data types and replace |
alexjfisher
approved these changes
Oct 10, 2018
|
@nbarrientos Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing it as a string the plugin will basically ignore the setting and write the following to the log file:
Without this patch it's not possible to declare different databases with different query interval.