Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RegexProcess has been renamed during collectd #896

Merged
merged 1 commit into from Nov 19, 2019

Conversation

mrunge
Copy link
Contributor

@mrunge mrunge commented Nov 18, 2019

review. It is now named ProcessRegex.

See https://github.com/collectd/collectd/blob/master/src/procevent.c#L1227

Fixes #897

@mrunge
Copy link
Contributor Author

mrunge commented Nov 18, 2019

Yay, CI is friendly to me.

Since the name of the parameter in collectd has been renamed, and the plugin is included in collectd-5.10, this should be fine.

Copy link
Contributor

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add label backwards incompatible, or change the code to accept both, but issue a warning for the wrong parameter name

@mrunge
Copy link
Contributor Author

mrunge commented Nov 19, 2019

Here is the thing, only this config is valid, the other one was only accepted in early versions of the plugin in collectd. The plugin itself was only recently merged into collectd-5.10.

The only possibility to have collectd accepting the currently implemented config (from puppet-collectd), you'd have to cherry-pick an early development snapshot of the plugin (more than a year old) and build collectd yourself. That is nothing, a regular user would do.

The other way around: chances are pretty high, that collectd won't accept the currently created config.

Does that make sense?

@igalic igalic merged commit d89bf53 into voxpupuli:master Nov 19, 2019
@igalic
Copy link
Contributor

igalic commented Nov 19, 2019

yes

@mrunge
Copy link
Contributor Author

mrunge commented Nov 19, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProcEvent plugin uses ProcessRegex instead of RegexProcess
2 participants