Add Mce log plugin #904
Merged
Add Mce log plugin #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrunge
reviewed
Jan 31, 2020
mrunge
reviewed
Jan 31, 2020
README.md
Outdated
| @@ -132,6 +132,7 @@ documentation for each plugin for configurable attributes. | |||
| * `hddtemp` (see [collectd::plugin::hddtemp](#class-collectdpluginhddtemp) below) | |||
| * `hugepages` (see [collectd::plugin::hugepages](#class-collectdpluginhugepages) below) | |||
| * `intel_pmu` (see [collectd::plugin::intel_pmu](#class-collectdpluginintel_pmu) below) | |||
| * `mcelog` (see [collectd::plugin::mcelog](#class-collectdpluginmcelog) below) | |||
There was a problem hiding this comment.
can you please move this down to keep the list sorted alphabetical?
There was a problem hiding this comment.
Moved it down.
bastelfreak
reviewed
Jan 31, 2020
templates/plugin/mcelog.conf.erb
Outdated
| @@ -0,0 +1,10 @@ | |||
| <Plugin mcelog> | |||
There was a problem hiding this comment.
can you please convert this to an epp template? We require this for new templates. For our other review guidelines please have a look at https://voxpupuli.org/docs/reviewing_pr/
There was a problem hiding this comment.
Converted to epp template
bastelfreak
reviewed
Jan 31, 2020
| let :facts do | ||
| facts | ||
| end | ||
|
|
There was a problem hiding this comment.
can you please also ensure that this compiles properly?
Something like this should work:
it { is_expected.to compile.with_all_deps }
bastelfreak
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intel Mcelog plugin https://collectd.org/documentation/manpages/collectd.conf.5.shtml#plugin_mcelog