write_http/disk is own sub package on CentOS 8 #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WIP until #919 is merge. |
traylenator
force-pushed
the
disks
branch
3 times, most recently
from
4d94fcc
to
4c35c1c
Compare
traylenator
changed the title
traylenator
changed the title
|
@traylenator do you want/need to rebase here? |
bastelfreak
approved these changes
Mar 10, 2020
bastelfreak
reviewed
Mar 10, 2020
| class collectd::plugin::write_http ( | ||
| Enum['present', 'absent'] $ensure = 'present', | ||
| Hash[String, Hash[String, Scalar]] $nodes = {}, | ||
| Hash[String, Hash[String, Scalar]] $urls = {} | ||
| Hash[String, Hash[String, Scalar]] $urls = {}, | ||
| Optional[Boolean] $manage_package = undef, |
There was a problem hiding this comment.
I'm not a big fan of an Optional Boolean. Can't we set the default to true or fals?
There was a problem hiding this comment.
In this case there are 3 states.
- Use the default for operating system (so false on debian, true on redhat 8)
- Force to be false.
- Force to be true.
bastelfreak
reviewed
Mar 10, 2020
As of CentOS 8 the write_http is in its own subpackage so must be installed on CentOS 8.
traylenator
changed the title
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
As of CentOS 8 the write_http and disk plugins are in their own subpackage
so must be installed on CentOS 8 in these plugins are enabled.
Note this also contains a bugfix for CentOS 7. On CentOS 7 at least as far
as EPEL7 collectd is concerned there is no collectd-disk package and so the attempt on
CentOS 7 to install this
collectd-disk(by default) is no longer made.acceptance tests for plugins have been added.