Add backwards compatibility in transition to Stdlib::Host #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch [1] changed all `port` parameters to use `Stdlib::Port`. When moving from String type to the new type, this patch is backwards incompatible leading to type errors when applying manifest. This patch is using Variant type to make this change backwards compatible and ease transition to new versions of puppet-collectd. [1] voxpupuli@d7b79c5
|
Hi @amoralej, We already made a backwards incompatible release for this so it's unlikely that we will fix this. It should not be a problem to update the local code before switching to our 12.0 release? |
I'll close this PR, i already workarounded the issue locally and was able to move on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch [1] changed all
portparameters to useStdlib::Port. Whenmoving from String type to the new type, this patch is backwards
incompatible leading to type errors when applying manifest. This patch
is using Variant type to make this change backwards compatible and ease
transition to new versions of puppet-collectd.
[1] d7b79c5
Pull Request (PR) description
This Pull Request (PR) fixes the following issues