Add options to limit the send queue length #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrunge
force-pushed
the
sendqueue
branch
2 times, most recently
from
9a070a4
to
81b55c1
Compare
|
Does anyone have an idea why CI fails on this? I mean, I see a lot of "errors", but they are not related to this change? |
|
Dear @mrunge, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
|
Is there a way to test this patch on top of another PR, like on #951 ? |
Collectd has the option to limit the send queue lenght for amqp1. This patch adds support for that. For reference, that was added in https://github.com/collectd/collectd/pull/3432/files
This reverts commit 9f098b8. It is only indirectly connected with the SendQueueLength patch.
including 0. The parameter should not become negative.
bastelfreak
reviewed
Aug 5, 2020
bastelfreak
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collectd has the option to limit the send queue lenght
for amqp1. This patch adds support for that.
For reference, that was added in
https://github.com/collectd/collectd/pull/3432/files