Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modulesync; Drop EoL CentOS 6 support #223

Merged
merged 8 commits into from Nov 9, 2022

Conversation

h-haaks
Copy link
Member

@h-haaks h-haaks commented Nov 5, 2022

Pull Request (PR) description

metadata.json Outdated
@@ -11,15 +11,15 @@
"dependencies": [
{
"name": "puppet/archive",
"version_requirement": ">= 1.0.0 < 6.0.0"
"version_requirement": ">= 1.0.0 < 5.0.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

puppet/mysql_java_connector does not support 5.x

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll start working on modulesync issues in puppet/mysql_java_connector so that we can get this inline as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for all the work. I made a new release for the mysql_java_connector.

metadata.json Outdated
},
{
"name": "puppet/mysql_java_connector",
"version_requirement": ">= 3.0.2 < 5.0.0"
},
{
"name": "puppetlabs/stdlib",
"version_requirement": ">= 4.13.1 < 9.0.0"
"version_requirement": ">= 4.13.1 < 7.0.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

puppet/mysql_java_connector does not support puppetlabs/stdlib >= 7.x

file { $jh:
ensure => directory,
} ->
archive { 'jdk11':
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch to Archive and zulu jdk8

download_url => #{download_url},
javahome => $jh,
version => '5.5.6',
jvm_type => 'oracle-jdk-1.8',
Copy link
Member Author

@h-haaks h-haaks Nov 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added jvm_type because jdk11 is the default but confluence 5.5.6 does not run on java11 ...

@h-haaks
Copy link
Member Author

h-haaks commented Nov 5, 2022

@bastelfreak is this ready for merge now?

@@ -32,14 +32,12 @@
{
"operatingsystem": "RedHat",
"operatingsystemrelease": [
"6",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acceptance tests failed on CentOS 6. Removed support since it's EOL

@h-haaks
Copy link
Member Author

h-haaks commented Nov 7, 2022

Fixes #211

@h-haaks
Copy link
Member Author

h-haaks commented Nov 7, 2022

I guess it also fixes #202

@bastelfreak bastelfreak changed the title Fix modulesync Fix modulesync; Drop EoL CentOS 6 support Nov 9, 2022
@bastelfreak
Copy link
Member

thanks for all the work!

@bastelfreak bastelfreak merged commit 9a57eaf into voxpupuli:master Nov 9, 2022
This was referenced Nov 9, 2022
@h-haaks h-haaks deleted the fix-modulesync branch November 9, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants