Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config_name parameter to define the name of the consul config #558

Merged
merged 1 commit into from Jan 15, 2021

Conversation

bogdankatishev
Copy link
Contributor

Add config_name parameter to give users the flexibility to name their config files in the name they want.

@solarkennedy
Copy link
Contributor

Seems fine, but can you tell me more about your use-case? Why not just have it be config.json?

@bogdankatishev
Copy link
Contributor Author

We will be using the upstream hashicorp consul package, which includes a Consul service file, which has this line: ConditionFileNotEmpty=/etc/consul.d/consul.hcl. So we will change the Consul config name to: consul.hcl.

And because hcl is JSON-compatible, the way of working will be the same.

@solarkennedy
Copy link
Contributor

Hmm.

@solarkennedy solarkennedy merged commit 815c488 into voxpupuli:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants