Make home directory location setting optional #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bastelfreak I am not sure I picked the right label here - feel free to change if I goofed |
bastelfreak
approved these changes
May 18, 2021
There was a problem hiding this comment.
I did some chatting with @genebean on IRC and I think this is the best approach to move forward. It worka for new and existing environments and in my opinion that is important.
|
@bastelfreak how do you feel about merging this and cutting a release? |
manifests/init.pp
Outdated
| @@ -117,6 +117,12 @@ | |||
| # [*manage_user*] | |||
| # Whether to create/manage the user that should own consul's configuration files. | |||
| # | |||
| # [*manage_user_home_location*] | |||
| # Whether to explicitly set the location of teh consul user's home directory when this modules | |||
| # manages the creation of the user. If the consul user already exists and this is enabled, puppet | |||
There was a problem hiding this comment.
Can you also note that this setting only takes effect if manage_user is true ?
There was a problem hiding this comment.
How does that look @solarkennedy ?
solarkennedy
approved these changes
May 25, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #559