Allow hash keys to be set to undef #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! Can you add a test to ensure this works fully and will continue to work? Something like... context "handles undef correctly" do
let(:params) => {{
config_hash => {
something => 'undef'? (maybe :undef ?)
}
}}
it { should compile }
it { should_not contain_file('consul.json').with_content(/: undef/)? }
end |
This patch protects against the case where hash values happen to be set to :undef (Puppet's nilish representation). Previously, having nil values set to null caused a stack trace, now, with this patch, those hash values are simply dropped. It also gets rid of some trailing white-spaces and adds some initial tests for the consul_sorted_json function.
bodepd
force-pushed
the
dont_fail_json_sort_on_fail
branch
from
03ee029
to
0a33716
Compare
|
Nice! |
solarkennedy
added a commit
that referenced
this pull request
Jan 10, 2015
Allow hash keys to be set to undef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch protects against the case where
hash values happen to be set to :undef (Puppet's
nilish representation). Previously, having nil
values set to null caused a stack trace, now,
with this patch, those hash values are simply
dropped.
It also gets rid of some trailing white-spaces