Update default consul version 1.2.3->1.16.1 #637
Conversation
bastelfreak
force-pushed
the
version
branch
2 times, most recently
from
829a86f
to
5ce4b26
Compare
| @@ -117,51 +117,7 @@ class { 'consul': | |||
| end | |||
|
|
|||
| describe command('consul version') do | |||
| its(:stdout) { is_expected.to match %r{Consul v1.2.0} } | |||
There was a problem hiding this comment.
the whole block was a duplicate, we don't need to test it multiple times.
bastelfreak
force-pushed
the
version
branch
2 times, most recently
from
b099ac6
to
05fb6ce
Compare
| String[1] $version = '1.2.3', | ||
| String[1] $version = '1.16.1', |
There was a problem hiding this comment.
I generally wonder if it is not better to not set any default version, and mandate the user to explicitly put what they want. This mean that we have to set an arbitrary version for testing, but we do not have to live with having to choose to default to an old-legacy-deprecated version after a few years or break backwards compatibility when a new version is available.
There was a problem hiding this comment.
I considered that and I don't know if I like it or not. We need to do a major release anyway so I thought it's a good time to bump the version, also consul supports upgrades between versions. I also doubt that most users are still on 1.2.3 because that's really really really old and not supported anymore.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues