Update based on voxpupuli/modulesync_config 0.16.3

[dhoppe]

Please merge. This is an requirement for the Coveralls badge at README.md.

[bastelfreak]

we shoukd probably update the nodeset in modulesync to also contain the other packages (of they are needed)

[bastelfreak]

that may be bad

[bastelfreak]

before we merge this we should readd the docker tests

[dhoppe]

I tried to add some Docker tests, but Beaker 3.1.0 does not support Ruby 2.1.9 and even if I pin it to Beaker 2.51.0 it fails with several error messages. However, a run time of 20 minutes is not acceptable.

.travis.yml:
  extras:
  - rvm: 2.1.9
    env: BEAKER_VERSION="~> 2.51" PUPPET_VERSION="~> 3.0" STRICT_VARIABLES="yes" CHECK=acceptance BEAKER_debug=true BEAKER_set=docker/centos-7 PUPPET_INSTALL_TYPE=foss PUPPET_INSTALL_VERSION=3.8.7
    services: docker
    sudo: required
    bundler_args: --without development
  - rvm: 2.1.9
    env: BEAKER_VERSION="~> 2.51" PUPPET_VERSION="~> 3.0" STRICT_VARIABLES="yes" CHECK=acceptance BEAKER_debug=true BEAKER_set=docker/ubuntu-14.04 PUPPET_INSTALL_TYPE=foss PUPPET_INSTALL_VERSION=3.8.7
    services: docker
    sudo: required
    bundler_args: --without development
  - rvm: 2.3.1
    env: BEAKER_VERSION="~> 2.51" PUPPET_VERSION="~> 4.0" CHECK=acceptance BEAKER_debug=true BEAKER_set=docker/centos-7 PUPPET_INSTALL_TYPE=agent PUPPET_INSTALL_VERSION=1.7.1
    services: docker
    sudo: required
    bundler_args: --without development
  - rvm: 2.3.1
    env: BEAKER_VERSION="~> 2.51" PUPPET_VERSION="~> 4.0" CHECK=acceptance BEAKER_debug=true BEAKER_set=docker/debian-8 PUPPET_INSTALL_TYPE=agent PUPPET_INSTALL_VERSION=1.7.1
    services: docker
    sudo: required
    bundler_args: --without development
  - rvm: 2.3.1
    env: BEAKER_VERSION="~> 2.51" PUPPET_VERSION="~> 4.0" CHECK=acceptance BEAKER_debug=true BEAKER_set=docker/ubuntu-14.04 PUPPET_INSTALL_TYPE=agent PUPPET_INSTALL_VERSION=1.7.1
    services: docker
    sudo: required
    bundler_args: --without development
  - rvm: 2.3.1
    env: BEAKER_VERSION="~> 2.51" PUPPET_VERSION="~> 4.0" CHECK=acceptance BEAKER_debug=true BEAKER_set=docker/ubuntu-16.04 PUPPET_INSTALL_TYPE=agent PUPPET_INSTALL_VERSION=1.7.1
    services: docker
    sudo: required
    bundler_args: --without development

[roidelapluie]

@dhoppe it is not really adding. We have the tests for a long time already

[dhoppe]

@roidelapluie The last successful build used Beaker 2.51.0, is 28 days ago and took 1 hour and 46 minutes.

I just want to get this merged and start working on the readme and code coverage of the rspec tests.

If we want to use acceptance tests properly, we need our own hardware or do this locally. Maybe someone else knows how to create the proper docker_image_comands and fix the configuration for Beaker 3.1.0.

[dhoppe]

I think the acceptance tests are failing because of the type at the nodesets. Puppet 3 needs the type set to foss and Puppet 4 to aio.

[roidelapluie]

travis fails

[dhoppe]

@roidelapluie I had to restart one of the build steps, because it was running for hours and just did a modulesync against 0.16.3.