Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final transfer changes #20

Merged
merged 1 commit into from Mar 6, 2024
Merged

Final transfer changes #20

merged 1 commit into from Mar 6, 2024

Conversation

h-haaks
Copy link
Member

@h-haaks h-haaks commented Mar 6, 2024

No description provided.

[![Puppet Forge - downloads](https://img.shields.io/puppetforge/dt/puppet/cpanm.svg)](https://forge.puppetlabs.com/puppet/cpanm)
[![Puppet Forge - endorsement](https://img.shields.io/puppetforge/e/puppet/cpanm.svg)](https://forge.puppetlabs.com/puppet/cpanm)
[![Puppet Forge - scores](https://img.shields.io/puppetforge/f/puppet/cpanm.svg)](https://forge.puppetlabs.com/puppet/cpanm)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add a badge for the license. and if you want you can add one for the migration/transfer. Check the puppet-openssl as an example.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code coverage badge just reports 'unknown'. ( copied it from puppet-jira )
Is there something that needs to be fixed for this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah branch master -> main :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to branch=main, but that didn't help...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bastelfreak I have added the license and transfer badges.
The coverage issue seems to be gha related, so I'll keep the badge for now.

Is it ok to merge this then?

@h-haaks h-haaks force-pushed the final-transfere-cleanup branch 2 times, most recently from ba94616 to 6f61578 Compare March 6, 2024 09:58
@h-haaks
Copy link
Member Author

h-haaks commented Mar 6, 2024

Should https://github.com/voxpupuli/puppet-cpanm/blob/main/CHANGELOG.md be renamed to HISTORY.md in this PR?
EDIT: I'll do this in a release branch later.

@h-haaks h-haaks requested a review from bastelfreak March 6, 2024 12:47
@h-haaks h-haaks merged commit 1bc3f92 into main Mar 6, 2024
19 checks passed
@h-haaks h-haaks deleted the final-transfere-cleanup branch March 6, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants