fsck: cvmfs-fsck.timer depends on cvmfs-fsck.service.

[olifre]

Pull Request (PR) description

cvmfs-fsck.timer should depend on cvmfs-fsck.service, otherwise they may be instantiated in different order.

This Pull Request (PR) fixes the following issues

Without this dependency, the error message:

cvmfs-fsck.timer: Refusing to start, unit cvmfs-fsck.service to trigger not loaded.

may appear during the first Puppet run, depending on resource evaluation order.

[traylenator]

Should migrate to systemd::timer of course and avoid this.

[olifre]

@traylenator Indeed, that seems like the much better approach! I must have missed that type in puppet-systemd until now.
I will update the PR later, switching to systemd::timer. Thanks!

[olifre]

@traylenator Looking at:
https://github.com/voxpupuli/puppet-systemd/blob/eaf66ff12c5b58ab41127f6979701d48c2304161/manifests/timer.pp
it seems puppet-systemd does not have this dependency as of yet, i.e. it might also fail. A fix does not seem to be entirely trivial, since systemd::timer also allows to not manage the service within that resource.

[traylenator]

Can't the conditional service be before the timer?

Not looked properly.

[olifre]

Can't the conditional service be before the timer?

👍

That would be a possibility indeed. Users managing the service themselves may still do things wrong by not setting before, but then it's a usage error ;-).
I'll then first do a PR against puppet-systemd (but not today) and then come back to this.

[olifre]

PR against puppet-systemd now open here:
voxpupuli/puppet-systemd#253

[olifre]

@traylenator Done, the latest force-push switches to systemd::timer and adapts the test suite accordingly :-).,