Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New parameter fuse3 to enable fuse3 variant #168

Merged
merged 1 commit into from May 10, 2023
Merged

New parameter fuse3 to enable fuse3 variant #168

merged 1 commit into from May 10, 2023

Conversation

traylenator
Copy link
Contributor

@traylenator traylenator commented May 3, 2023 •
edited

Pull Request (PR) description

If parameter fuse3 is set true (defaults undef) then
install the fuse3 variant of cvmfs.

If parameter fuse3 is set false (defaults undef) then
it will remove the fuse3 variant of cvmfs.

With default undef nothing will happen.

@traylenator traylenator marked this pull request as draft May 3, 2023 14:41
@traylenator
Copy link
Contributor Author

@jblomer There is no cvmfs-fuse3 package for ubuntu & debian ?

@jblomer
Copy link
Contributor

jblomer commented May 3, 2023

There is, see for instance http://ecsft.cern.ch/dist/cvmfs/cvmfs-2.10.1/

@traylenator traylenator force-pushed the fuse3 branch 3 times, most recently from 66acee5 to 542d8dc Compare May 4, 2023 10:07
@traylenator
Copy link
Contributor Author

@olifre you know what is going on here? Rubbish with debian and friends.

@traylenator traylenator force-pushed the fuse3 branch 2 times, most recently from 298b01a to 71aa9ad Compare May 4, 2023 11:30
@olifre
Copy link
Contributor

olifre commented May 4, 2023

@olifre you know what is going on here? Rubbish with debian and friends.

That was interesting indeed — we are effectively / implicitly already using the fuse3 variant on Debian 11 since quite a while, as it is pulled in by the cvmfs package there, so there should not be a general issue.
It seems the last push has fixed the issue (the cvmfs_config killall is new, I guess)?

Only Ubuntu 18.04 is out since it is too old for fuse3 I think.

@traylenator
Copy link
Contributor Author

Yeah migrating to fuse3 does require a restart really , reload is not enough. I'll add something to the parameter notes.

As for 18.03 it has 27 days till end of life.

@traylenator traylenator added the enhancement New feature or request label May 4, 2023
@traylenator traylenator marked this pull request as ready for review May 4, 2023 13:35
@traylenator traylenator mentioned this pull request May 5, 2023
Merged
luisfdez
luisfdez approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@luisfdez luisfdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a last comment to the code but I don't have a strong opinion about it. Otherwise, I think it looks good.

manifests/install.pp Outdated Show resolved Hide resolved
@traylenator
New parameter fuse3 to enable fuse3 variant
7968c15 
If parameter `fuse3` is set `true` (defaults `false`) then
install the fuse3 variant of cvmfs.
@traylenator traylenator merged commit c89863f into voxpupuli:master May 10, 2023
15 checks passed
@traylenator traylenator deleted the fuse3 branch May 10, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisfdez luisfdez luisfdez approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@traylenator @jblomer @olifre @luisfdez