Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I've configured this module to point to OSG cvmfs package, but can't install them #30

Merged
merged 2 commits into from
May 6, 2015

Conversation

jcpunk
Copy link
Contributor

@jcpunk jcpunk commented May 1, 2015

I've configured this module to point to OSG cvmfs package, but can't install them.

Since the OSG packages have different GPG keys, I'd like to set gpg validation for this alternate key.

@@ -53,6 +53,9 @@
# or an exact version number of the package.
$major_release = regsubst($::operatingsystemrelease,'^(\d+)\.\d+$','\1')
$cvmfs_version = hiera('cvmfsversion','present')
$cvmfs_yum_gpgcheck = hiera('cvmfs_yum_gpgcheck','1')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As before

$cvmfs_yum_gpgcheck = 1

and drop the hiera call here so I don't have to deprecate it.

@traylenator
Copy link
Contributor

Fine in principal , if you can remove the hiera calls, squash the commits and add a tests.

@jcpunk
Copy link
Contributor Author

jcpunk commented May 4, 2015

hiera removed, squashed into one

traylenator added a commit that referenced this pull request May 6, 2015
@jcpunk - Thanks for the patch.
I've configured this module to point to OSG cvmfs package, but can't install them
@traylenator traylenator merged commit b0b1cb5 into voxpupuli:master May 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants