cleanup: update metadata.json license #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd also suggest to disable Rubocop initially and fix it up later. We have https://github.com/voxpupuli/gha-puppet#basic-tests, but don't expose this in our modulesync config. I'd just patch it up manually now. |
This PR removes updates the licence in the metadata.json file to match the LICENCE file in the repo
b4ldr
changed the title
bastelfreak
changed the title
bastelfreak
approved these changes
Jan 27, 2023
|
That's fine. The expat license is one of the variants of the MIT license. Without the advertisement clause etc. But I think MIT license as defined by OSI is identical to expat license. |
|
@dalen awesome thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rupdates the licence in the metadata.json file to match the LICENCE file in the repo
@dalen can you just confirm this PR, i wouldn't want to accidentally change your licencing intentions, thanks