Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNS-SOA record. #123

Merged
merged 3 commits into from Feb 3, 2023
Merged

Add DNS-SOA record. #123

merged 3 commits into from Feb 3, 2023

Conversation

Heidistein
Copy link
Contributor

Bit different, this one returns a hash with the fields. This is a
present from the Ruby resolver class.

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

 Bit different, this one returns a hash with the fields. This is a
 present from the Ruby resolver class.
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only minor fixes.

lib/puppet/functions/dns_soa.rb Outdated Show resolved Hide resolved
spec/functions/dns_soa_spec.rb Outdated Show resolved Hide resolved
spec/functions/dnsquery_soa_spec.rb Outdated Show resolved Hide resolved
Also, the shebang is invalid, so remove it and remove the x-bit
@bastelfreak
Copy link
Member

thanks for the work!

@bastelfreak bastelfreak merged commit 2f7e652 into voxpupuli:master Feb 3, 2023
@b4ldr
Copy link
Member

b4ldr commented Feb 3, 2023

thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants