TXT: join text records #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b4ldr
force-pushed
the
join_txt_records
branch
4 times, most recently
from
bcf5495
to
2d4d2dd
Compare
TXT records that are larger then 255 characters are split into chunks. This means that the result of a TXT record is always Array[Array[String]]. This 355 character limit is more a detail about DNS which is not very useful when presenting data to higher interfaces. as such join the inner elements so we have a more normalise Array[String] return_type This is a backwards incompatible breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TXT records that are larger then 255 characters are split into chunks. This means that the result of a TXT record is always Array[Array[String]].
This 255 character limit is more a detail about DNS which is not very useful when presenting data to higher interfaces. as such join the inner elements so we have a more normalise Array[String] return_type
This is a backwards incompatible breaking change