Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config_info: Allow users to override the resolver config #129

Merged
merged 1 commit into from Apr 20, 2023

Conversation

b4ldr
Copy link
Member

@b4ldr b4ldr commented Feb 17, 2023

This PR allows useres to set the following:

  • nameservers
  • ndots
  • search

reimplements #10

@b4ldr
Copy link
Member Author

b4ldr commented Feb 17, 2023

Ci failures seems a bit strange to me i.e. i would expect it to fail for all or none. Perhaps an actual dns issue, will look again later

@kenyon kenyon changed the title config_info: Allow useres to override the resolver config config_info: Allow users to override the resolver config Apr 13, 2023
REFERENCE.md Outdated Show resolved Hide resolved
@b4ldr b4ldr force-pushed the options_override branch 3 times, most recently from 0fb194b to 078f607 Compare April 14, 2023 10:26
@b4ldr
Copy link
Member Author

b4ldr commented Apr 14, 2023

no idea why but cname for en.wikipedia.org and soa for google.com seem to be failing (works locally)

@b4ldr b4ldr force-pushed the options_override branch 2 times, most recently from 5a27c8d to 450ebfb Compare April 14, 2023 16:00
@b4ldr
Copy link
Member Author

b4ldr commented Apr 14, 2023

no idea why but cname for en.wikipedia.org and soa for google.com seem to be failing (works locally)

fixed.

@b4ldr b4ldr requested a review from smortex April 14, 2023 16:02
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I just feel annoyed by the code duplication, but I am not sure about the best way to handle this.

lib/puppet/functions/dnsquery/a.rb Outdated Show resolved Hide resolved
@b4ldr b4ldr force-pushed the options_override branch 2 times, most recently from 929e53b to 1e3af9a Compare April 20, 2023 11:25
This PR allows users to set the following:
 * nameservers
 * ndots
 * search

reimplements #10
@b4ldr b4ldr merged commit 187197e into master Apr 20, 2023
4 checks passed
@b4ldr b4ldr deleted the options_override branch April 20, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants