New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config_info: Allow users to override the resolver config #129
Conversation
ef0f1ec
to
83c9946
Compare
Ci failures seems a bit strange to me i.e. i would expect it to fail for all or none. Perhaps an actual dns issue, will look again later |
0fb194b
to
078f607
Compare
no idea why but cname for en.wikipedia.org and soa for google.com seem to be failing (works locally) |
5a27c8d
to
450ebfb
Compare
fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, I just feel annoyed by the code duplication, but I am not sure about the best way to handle this.
929e53b
to
1e3af9a
Compare
This PR allows users to set the following: * nameservers * ndots * search reimplements #10
This PR allows useres to set the following:
reimplements #10