Allow enabled SSL protocols to be specified

[aadamovich]

Pull Request (PR) description

When using download_file on some Windows systems against files on GitHub, I received:

• FullyQualifiedErrorId : The request was aborted: Could not create SSL/TLS secure channel.

It appears that system didn't have all the SSL protocols enabled on group policy level, which I cannot change at the moment.

This pull request creates a workaround allowing to specify which protocol to use when downloading files.

Example:

  download_file { 'Download git':
    url                   => 'https://github.com/git-for-windows/git/releases/download/v2.19.2.windows.1/Git-2.19.2-64-bit.exe',
    security_protocol     => 'tls12',
    destination_directory => 'C:/software',
  }

[bastelfreak]

Hi @aadamovich, thanks for the PR. Can you please squash the commits into one and take a look at the inline comment I made?

[aadamovich]

Hi @bastelfreak, I have changed the pp file according to your comments. Regarding squashing, isn't that something that GitHub supports when you press merge button? https://blog.github.com/2016-04-01-squash-your-commits/

[bastelfreak]

Hi @aadamovich, we always prefer it when the contributors provide a sane git history. Squashing all commits into a single one isn't the best solution for most situations.

[alexjfisher]

@bastelfreak Did this supercede #68 ?