Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different paths for elasticsearch-plugin #1181

Merged
merged 2 commits into from Jan 4, 2023

Conversation

phaedriel
Copy link
Contributor

@phaedriel phaedriel commented Dec 29, 2022

Pull Request (PR) description

  • Add test path binary 'plugin'

Ref : https://discuss.elastic.co/t/missing-plugin-command-in-elastic/61995/2 > "elasticsearch-plugin is only applicable for 5.0 and above. if you are really on 2.4 then you need to use /usr/share/elasticsearch/bin/plugin."

This Pull Request (PR) fixes the following issues

Fixes #1172
Fixes #1109

@phaedriel phaedriel force-pushed the plugin_binary branch 2 times, most recently from f4e3ece to 78197ee Compare December 29, 2022 17:42
@smortex
Copy link
Member

smortex commented Dec 29, 2022

Do you really want to fix/add support for ES < 5? As far as I can tell, anything older than 7.13.x is not supported:

https://www.elastic.co/fr/support/eol

Maybe we can just close the issue?

@phaedriel
Copy link
Contributor Author

Do you really want to fix/add support for ES < 5? As far as I can tell, anything older than 7.13.x is not supported:

https://www.elastic.co/fr/support/eol

Maybe we can just close the issue?

  • solution 1 : we add this small modification (i could add a comment to better explain in ruby code)
  • solution 2 : i rollback and we suppress this indication "2.x" in readme (module description) "This module is actively tested against Elasticsearch 2.x, 5.x, and 6.x."

as you prefer ;)

Copy link
Member

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine. This doesn't hardcode any paths with a version in it. It's possible that distros buil their own elasticsearch packages and use the old path.

@smortex smortex merged commit 791f7d6 into voxpupuli:master Jan 4, 2023
@bastelfreak bastelfreak added the enhancement New feature or request label Jan 5, 2023
@bastelfreak bastelfreak changed the title Test binary path elasticsearch-plugin Support different paths for elasticsearch-plugin Jan 5, 2023
@bastelfreak bastelfreak changed the title Support different paths for elasticsearch-plugin Support different paths for elasticsearch-plugin Jan 5, 2023
@phaedriel phaedriel deleted the plugin_binary branch January 7, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants