Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Extlib::CIDR DataType #222

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add Extlib::CIDR DataType #222

wants to merge 1 commit into from

Conversation

jay7x
Copy link
Member

@jay7x jay7x commented Apr 1, 2024

Example:

$ip = Extlib::CIDR('192.168.1.0/24')
notice $ip.host_min, $ip.host_max

@jay7x jay7x force-pushed the cidr_type branch 2 times, most recently from f97e1a6 to c90c87c Compare April 1, 2024 18:00
Example:
```
$ip = Extlib::CIDR('192.168.1.0/24')
notice $ip.host_min, $ip.host_max
```
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know this was possible. There are various types in stdlib (https://github.com/puppetlabs/puppetlabs-stdlib/tree/main/types/ip) and I wonder if this should live in stdlib instead.

@davidsandilands
Copy link
Sponsor Member

From discussion in DevX channel we would agree with approach but it would make sense to be in stdlib.

@jay7x
Copy link
Member Author

jay7x commented Apr 3, 2024

Thank you for the update! I'll add unit tests and raise a similar PR to the stdlib repo this weekend then! 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants