Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework module post-fork #1

Merged
merged 2 commits into from May 23, 2022
Merged

Rework module post-fork #1

merged 2 commits into from May 23, 2022

Conversation

genebean
Copy link
Contributor

No description provided.

@puppet-community-rangefinder
Copy link

falco::params is a class

that may have no external impact to Forge modules.

falco::repo is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 579 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@genebean genebean force-pushed the updates branch 9 times, most recently from 602c9b9 to 1a6b955 Compare May 23, 2022 14:32
@genebean genebean changed the title Make imported code actually work Rework module post-fork May 23, 2022
bastelfreak
bastelfreak reviewed May 23, 2022
View reviewed changes
.fixtures.yaml Outdated Show resolved Hide resolved
bastelfreak
bastelfreak reviewed May 23, 2022
View reviewed changes
.fixtures.yaml Outdated Show resolved Hide resolved
@genebean genebean force-pushed the updates branch 2 times, most recently from 73fe718 to 4bc8988 Compare May 23, 2022 14:57
@genebean genebean marked this pull request as ready for review May 23, 2022 14:57
@genebean
Rework module post-fork
70e8e46 
The moudle has been reworked to fix broken code and to bring it up to
modern coding standards. It has also been updated to adhere to Vox
Pupuli's module standards by incorporating changes applied via
modulesync.
@genebean genebean merged commit 3f0eb8e into main May 23, 2022
@genebean genebean deleted the updates branch May 23, 2022 19:10
@genebean genebean mentioned this pull request May 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak left review comments

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@genebean @bastelfreak