New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for my use cases #170
Open
kBite
wants to merge
17
commits into
voxpupuli:master
Choose a base branch
from
kBite:add-support-for-my-use-cases
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kBite
force-pushed
the
add-support-for-my-use-cases
branch
2 times, most recently
from
January 29, 2024 19:36
0c9b852
to
c1a8056
Compare
Please update REFERENCE.md with $ bundle exec rake strings:generate:reference Add it to the PR and CI should continue. |
align parameters of defined type 'rule' align parameters in manifests/chain.pp update header for better readability
If 'Ferm::Actions' is equal to some defined strings or any non-empty string it's almost useless. For this reason the defined type 'rule' has to reiterate testing against the same Enum to get useful information from it. 'Ferm::Actions' is used in 'rule' and 'ipset'. The later does not seem to require jumping. update spec/type_aliases/actions_spec.rb
kBite
force-pushed
the
add-support-for-my-use-cases
branch
from
January 30, 2024 11:05
1915369
to
fe778fb
Compare
- Originally 'daddr' and 'saddr' were of data type 'Variant[Array, String[1]]' - In case of Array code matched against 'Array[Stdlib::IP::Address]' Keeping 'String[1]' for compatibility
replace single long line with heredoc
iptables syntax: ``` -A FORWARD -o docker0 -m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT ``` ferm syntax: ``` table filter FORWARD outerface docker0 mod conntrack ctstate (ESTABLISHED RELATED) ACCEPT; ```
kBite
force-pushed
the
add-support-for-my-use-cases
branch
from
January 30, 2024 13:59
fe778fb
to
8acfc06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some "idempotent" (non user-visible) changes
rule
moving boilerplate to new functionrule
with some new data typesadd support for my use cases
outerface
,daddr_type
,saddr_type
, andctstate
Of course, everything comes with tests and documentation. I didn't add tests for the function though, because I'd consider it tested indirectly as part of tests done on
rule
.EDIT: Tests are failing due to outdated
REFERENCE.md
. Can't findredcarpet
right now. Tried ...... but still:
Will dig deeper tomorrow.