General code modernisation - assorted bugfixes. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defaults for all parameters moved from params.pp to init.pp All hiera variables are now finally completly removed after a long deprecation window. * fetchcrl_pkg_version removed , use fetchcrl::pkg_version * fetchcrl_proxy removed, use fetchcrl::proxy * fetchcrl_capkgs removed, use fetchcrl::capkgs * fetchcrl_carepo removed, use fetchcrl::carepo * fetchcrl_capkgs_version removed, use fetchcrl::capkgs_version
In adition to the template conversion there were some parts of the template that could never be reached and should not have been there.
These keywords are added to the config file or not. Consequently undef is a bad default. It never takes a difference action to false.
A new noerrors parameter can now be set to true to supress errors from fetch-crl. Fixes voxpupuli#43 Fixes voxpupuli#44
Completly new spec test for `fetchcrl::ca` Discovered a bug with ageing vs aging one parameter name.
ekohl
reviewed
Nov 29, 2018
Use ```puppet Variant[Undef,X] $x = undef ``` instead of ```puppet Optional[X] $x = undef ```
alexjfisher
reviewed
Nov 29, 2018
alexjfisher
changed the title
|
Updated title to include WIP. (Mainly to test the WIP plugin and branch protection configuration if I'm being honest!). |
|
Should I remove the WIP once ready again? |
|
@traylenator Sorry for using you and your PR as a guinea pig! |
traylenator
changed the title
traylenator
added
bug
ekohl
approved these changes
Dec 1, 2018
|
@ekohl @alexjfisher thanks for the comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
A number of commits addressing:
noerrrorsto suppress fetch-crl error messages at runtime.This Pull Request (PR) fixes the following issues
Fixes #43 Add noerrors parameter.
Fixes #44 Add noerrors parameter.
FIxes #45 Use lookup function not hiera.