Update from voxpupuli modulesync_config #17
Conversation
|
This may take a while. |
|
This will require a significant refactor of the tests. |
|
Calling for help on this one. @bastelfreak @nibalizer ? |
|
As master is at the moment, the critical gems used when testing against Ruby 1.9.3 are: puppet 4.3.2, facter-2.4.6, rspec 2.10.0 and mocha 0.10.5 . I would pin these in the Gemfile and move your way up slowly taking note of deprecation warnings - rspec 2.10.0 and mocha 0.10.5 breaking changes are most likely the culprit |
| # generate hash of {provider_name => provider} | ||
| providers = instances.inject({}) do |hash, instance| | ||
| providers = instances.each_with_object({}) do |instance, hash| |
There was a problem hiding this comment.
each_with_object is not available in Ruby 1.8.7, but you probably knew that already
There was a problem hiding this comment.
Yes. We actually dropped Ruby 1.8.7 support. There should likely be a changelog entry.
|
Tag @juniorsysadmin for review. I think this is good to merge; we will likely need at least some scream tests due to the amount of work this module had previously (not much).... |
| @@ -1,6 +1,17 @@ | |||
| CHANGELOG | |||
| ========= | |||
|
|
|||
| 1.2.0 | |||
There was a problem hiding this comment.
This used to test against Ruby 1.8.7 but we never said it was supported in the docs, so I am fine with this versioning.
|
Looks reasonable to me |
|
This module of course needs a Travis token in in order for releases to be pushed, so see the appropriate people about this. |
|
Tagging @nibalizer for the secret. |
|
@juniorsysadmin @nibalizer just got me a secret, so it looks good now. |
Update from voxpupuli modulesync_config
No description provided.