Add sources to zones #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows you to add sources to zones
|
Tested it out and I seem to be getting this message intermittently (?) I haven't had time to look into it in too much detail Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Invalid parameter sources on Firewalld_zone[zone_name] The sources are defined, as I've been using my build from #23 to test it.. the only thing i changed was source to sources - one is a array list and the other is a hiera_array. They are all custom zones, i'm not touching the per-existing ones. I'll simplify the tests to see if i can work out exactly what the issue is when I have more time. |
Merged
|
#32 will be merged (merge conflict fix) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to carve your zones into segments using sources
This PR probably redoes whatever #23 should do, although #23 seems not to be complete according to the comments.