Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the protocols to custom_service #335

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Pass the protocols to custom_service #335

wants to merge 1 commit into from

Conversation

jovandeginste
Copy link
Contributor

Pull Request (PR) description

This allows you to specify protocols in through firewalld::custom_service, which are then passed on to firewalld_custom_service.

Signed-off-by: Jo Vandeginste Jo.Vandeginste@kuleuven.be

@jovandeginste
Pass the protocols to custom_service
782d59c 
Signed-off-by: Jo Vandeginste <Jo.Vandeginste@kuleuven.be>
@jcpunk
Copy link
Contributor

jcpunk commented Jan 25, 2023

Can you add some unit tests to this?

Here is an example commit with some testing : 55ed8ab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-rebase needs-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jovandeginste @jcpunk