Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing badges #25

Merged
merged 3 commits into from Oct 23, 2016
Merged

Add missing badges #25

merged 3 commits into from Oct 23, 2016

Conversation

dhoppe
Copy link
Member

@dhoppe dhoppe commented Oct 23, 2016

No description provided.

bastelfreak
bastelfreak reviewed Oct 23, 2016
View reviewed changes
CONTRIBUTING.md
at least need `BEAKER_PROVISION` set to yes (the default). The Vagrantfile
for the created virtual machines will be in `.vagrant/beaker_vagrant_fies`.

# vim: syntax=markdown
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has to be removed

@bastelfreak
Copy link
Member

@dhoppe we have the CONTRIBUTIG.md in .github/, and this is managed via modulesync. I'm not sure if we should have it twice in the repo. Can we symlink it or manage both via modulesync?

@bastelfreak bastelfreak mentioned this pull request Oct 23, 2016
Merged
@dhoppe
Copy link
Member Author

dhoppe commented Oct 23, 2016

Regarding to this blog post, you can put CONTRIBUTING.md, ISSUE_TEMPLATE.md and PULL_REQUEST_TEMPLATE.md into the .github directory. But I do not know how CONTRIBUTING.md is supposed to work, since this is no template and shown anywhere.

Actually all of our modules have the CONTRIBUTING.md and .github/CONTRIBUTING.md. The first one does not get rolled out via modulesync and is different than the other one.

I think we should move the file out of .github, because the user should be able to see this file quickly.

@bastelfreak
Copy link
Member

It is linked to you if you open up a PR. I will open an issue in modulesync_config so we can decide it later.

@bastelfreak bastelfreak merged commit a1f752b into voxpupuli:master Oct 23, 2016
@dhoppe dhoppe deleted the readme branch October 23, 2016 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dhoppe @bastelfreak