is_hash, is_array, and is_any are depricated

[james-powis]

reference: https://github.com/puppetlabs/puppetlabs-stdlib
and example of replacement: https://github.com/puppetlabs/puppetlabs-ntp/blob/master/manifests/init.pp#L17-L28

[tobru]

Thanks! We'll update the module over the next weeks...

[iainhallam]

Same for validate_bool, apparently (at least, I get warnings) in Puppet agent > 4.

[pgassmann]

For reference and search, the deprecation messages:
method is deprecated, please use the stdlib validate_legacy function

Warning: This method is deprecated, please use the stdlib validate_legacy function, with Stdlib::Compat::Bool. There is further documentation for validate_legacy function in the README. at ["/x/modules/gitlab/manifests/init.pp", 339]:["/x/site/role/manifests/gitlab.pp", 2]
   (at /x/modules/stdlib/lib/puppet/functions/deprecation.rb:25:in `deprecation')
Warning: This method is deprecated, please use the stdlib validate_legacy function, with Stdlib::Compat::String. There is further documentation for validate_legacy function in the README. at ["/x/modules/gitlab/manifests/init.pp", 342]:["/x/site/role/manifests/gitlab.pp", 2]
   (at /x/modules/stdlib/lib/puppet/functions/deprecation.rb:25:in `deprecation')
Warning: This method is deprecated, please use the stdlib validate_legacy function, with Pattern[]. There is further documentation for validate_legacy function in the README. at ["/x/modules/gitlab/manifests/init.pp", 344]:["/x/site/role/manifests/gitlab.pp", 2]
   (at /x/modules/stdlib/lib/puppet/functions/deprecation.rb:25:in `deprecation')
Warning: This method is deprecated, please use the stdlib validate_legacy function, with Stdlib::Compat::Absolute_Path. There is further documentation for validate_legacy function in the README. at ["/x/modules/gitlab/manifests/init.pp", 351]:["/x/site/role/manifests/gitlab.pp", 2]
   (at /x/modules/stdlib/lib/puppet/functions/deprecation.rb:25:in `deprecation')
Warning: This method is deprecated, please use the stdlib validate_legacy function, with Stdlib::Compat::Hash. There is further documentation for validate_legacy function in the README. at ["/x/modules/gitlab/manifests/init.pp", 364]:["/x/site/role/manifests/gitlab.pp", 2]
   (at /x/modules/stdlib/lib/puppet/functions/deprecation.rb:25:in `deprecation')

[iainhallam]

Was this fixed, then?

[LongLiveCHIEF]

yep! I was going through all issues last night to make sure we cleaned any up, and I couldn't remember the exact commit/merge where this was fully resolved or I would have linked it. I'm fairly sure though that the first release containing this fix was in v1.16.0.