Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for current releases #41

Merged
merged 2 commits into from Dec 3, 2019
Merged

Add support for current releases #41

merged 2 commits into from Dec 3, 2019

Conversation

dhoppe
Copy link
Member

@dhoppe dhoppe commented Apr 26, 2019

No description provided.

@dhoppe
Copy link
Member Author

dhoppe commented Apr 26, 2019

The acceptance tests should also provide a running GitLab instance where the GitLab runner can connect to.

@dhoppe dhoppe added enhancement New feature or request needs-work not ready to merge just yet labels Apr 26, 2019
@LongLiveCHIEF
Copy link
Contributor

@dhoppe I don't think we need a gitlab instance to do acceptance testing. I think we could mock anything needed for this. You could wind up with false failures if problems occur with the gitlab instance launch.

GitLab does acceptance testing on all the features that runner uses to connect with GitLab, so it would be redundant to do all that work when all we really need to focus on with puppet is that it is managing the state in the way we expect.

@LongLiveCHIEF
Copy link
Contributor

That being said, if for some reason I haven't thought of that we do need an instance, I think going with the dockerized gdk would be the best bet. It pre-loads data and everything and is an ideal platform for running acceptance tests against.

Downside is that startup takes quite a while, and we'd needs to find a way to cache this so each job in a run wouldn 't need to spin it up.

@baurmatt
Copy link
Contributor

baurmatt commented Dec 3, 2019

This looks good to me! :)

@dhoppe Could you please rebase you branch and fix the merge conflict? :)

@baurmatt
Copy link
Contributor

baurmatt commented Dec 3, 2019

Thank you! :)

@baurmatt baurmatt merged commit 9999769 into voxpupuli:master Dec 3, 2019
cegeka-jenkins pushed a commit to cegeka/puppet-gitlab_ci_runner that referenced this pull request May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-work not ready to merge just yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants