Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apt public key for gluster.org changed address #102

Closed
martialblog opened this issue Feb 6, 2017 · 5 comments
Closed

Apt public key for gluster.org changed address #102

martialblog opened this issue Feb 6, 2017 · 5 comments

Comments

@martialblog
Copy link
Contributor

martialblog commented Feb 6, 2017

Tried to use puppet-gluster (with 3.9) on Debian 8 and noticed that the apt repository installation failed because the public key is no longer at: https://download.gluster.org/pub/gluster/glusterfs/LATEST/rsa.pub

For 3.9 it's at:
https://download.gluster.org/pub/gluster/glusterfs/3.9/rsa.pub

For other versions it's at:
https://download.gluster.org/pub/gluster/glusterfs/VERSION/LATEST/rsa.pub

I'll have a look at the module and (hopefully) provide a fix soon...

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 4.6.0
  • Module version: 2.3.0

How to reproduce (e.g Puppet code you use)

class { gluster::install:
  server  => true,
  repo    => true,
}

Output log

Error: /Stage[main]/Gluster::Repo::Apt/Apt::Source[glusterfs-LATEST]/Apt::Key[Add key: A4703C37D3F4DE7F1819E980FE79BB52D5DC52DC from Apt::Source glusterfs-LATEST]/Apt_key[Add key: A4703C37D3F4DE7F1819E980FE79BB52D5DC52DC from Apt::Source glusterfs-LATEST]/ensure: change from absent to present failed: 404 Not Found for https://download.gluster.org/pub/gluster/glusterfs/LATEST/rsa.pub

@martialblog
Copy link
Contributor Author

This worked for me, but I wanna see if there's a better solution: https://github.com/martialblog/puppet-gluster/commit/59ca85c945f1fcf87a37ba89fde600ac89d5803c

Since it's going to probably not work with the next release. The directory structure on gluster.org unfortunately differs a bit for some releases.

Also asked the gluster.org Mailing List what's going on here...

@martialblog
Copy link
Contributor Author

martialblog commented Feb 8, 2017

Hi,

I decided to refator the gluster::repo::apt class. The Key ID and Download URL Parameter are replaced by 'release' which will then set them accordingly.

Also added tests for this.
https://github.com/martialblog/puppet-gluster/commit/51412473bcce639710901db2e9aa287c41efebd2
Feedback would be appreciated.

Cheers

@dhoppe
Copy link
Member

dhoppe commented Feb 8, 2017

This looks great, could you please create an PR?

@martialblog
Copy link
Contributor Author

Unfortunately no response from the gluster.org Team yet.
http://lists.gluster.org/pipermail/gluster-users/2017-February/029930.html

@martialblog
Copy link
Contributor Author

Fixed with version 3.0.0

I'll look into writing some Beaker acceptance tests so this can be avoided in the future...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants