Repo refactor #103
Merged
Repo refactor #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok the RuboCop Check failed... I'll have a look at that |
|
Just now rebased the branch |
bastelfreak
reviewed
Feb 12, 2017
spec/spec_helper.rb
Outdated
| @@ -24,8 +24,8 @@ | |||
| puppetversion: Puppet.version, | |||
| facterversion: Facter.version | |||
| } | |||
| default_facts.merge!(YAML.load(File.read(File.expand_path('../default_facts.yml', __FILE__)))) if File.exist?(File.expand_path('../default_facts.yml', __FILE__)) | |||
| default_facts.merge!(YAML.load(File.read(File.expand_path('../default_module_facts.yml', __FILE__)))) if File.exist?(File.expand_path('../default_module_facts.yml', __FILE__)) | |||
| default_facts.merge!(YAML.safe_load(File.read(File.expand_path('../default_facts.yml', __FILE__)))) if File.exist?(File.expand_path('../default_facts.yml', __FILE__)) | |||
There was a problem hiding this comment.
please check this again. I think the rebase didn't work as expected. We should stay with YAML.load.
|
Hi @martialblog, thanks for the PR! Can you please check the spec/spec_helper.rb again? After thats gone from the PR I'm happy to merge + release. |
- Added release parameter - Key ID and download url are no longer parameters - Key ID and download get set depending on release parameter
|
Hey @bastelfreak, all done. Should look good now. |
|
thanks! |
|
Hi @martialblog, I just released a new version: https://forge.puppet.com/puppet/gluster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #102