Remove 3.8 repo, use pl-apt 4.4 https support, clean coding

[ekohl]

No description provided.

[bastelfreak]

Hi @ekohl, can you rebase please?

[ekohl]

Rebased

[ekohl]

Rebased again

[bastelfreak]

Notice: /Stage[main]/Apt::Update/Exec[apt_update]/returns: E: The method driver /usr/lib/apt/methods/https could not be found.

Why do I have a feeling that https for apt is broken every two weeks? :(

[ekohl]

Could be. Wonder if there's some chaining missing.

[dhoppe]

@ekohl I think you should not remove the package apt-transport-https and fix the value of repo_url, because the web server makes an redirect vom http to https.

[ekohl]

Because puppetlabs-apt is supposed to guarantee that: https://github.com/puppetlabs/puppetlabs-apt/blob/0dba15a9c62ce4d98435eac89e0087a2ad00ce10/manifests/source.pp#L85-L94

[dhoppe]

@ekohl Cool. I must have been away too long, but now you need to fix the protocol for the tests aswell. But I am still not sure about this change #184.

[ekohl]

I did copy that part yes because I think it's more correct. I can leave it out for now and merge it in a separate PR.

[ekohl]

Updated. The http -> https URL change should also fix the failing puppetlabs-apt tests. That does a regex on the URL to decide.

[bastelfreak]

would it make sense to convert this into a datatype?

[ekohl]

Not that much because AFAIK you can't really extract variables from a data type like we do in the case below. You could avoid the else case at the end, but an if/elsif/elsif tree without an else feels wrong to me.

[bastelfreak]

@ekohl can you please rebase and give me a hint afterwards? I would like to review and merge this as soon as possible.

[ekohl]

Rebased

[bastelfreak]

can you take a look at the failing spec tests?

[ekohl]

Updated

[bastelfreak]

thanks!