Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make volume ensurable #219

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Make volume ensurable #219

merged 1 commit into from
Aug 28, 2020

Conversation

glorpen
Copy link
Contributor

@glorpen glorpen commented Aug 14, 2020

Pull Request (PR) description

Adds ensure parameter for gluster::volume type with support for present and absent values.

This Pull Request (PR) fixes the following issues

n/a

Since this diff could be hard to read, it was enough to add 2x if $ensure == 'present' and 1x exec { "gluster stop and remove ${title}": :)

@glorpen
Copy link
Contributor Author

glorpen commented Aug 20, 2020

@ekohl Sorry for pinging you out of the blue but could you look at 3 waiting PRs? #215 , this one and #220.

@ekohl
Copy link
Member

ekohl commented Aug 27, 2020

Looks good, but needs a rebase to fix the merge conflict. Mind also squashing the commits while you're at it?

@glorpen
Copy link
Contributor Author

glorpen commented Aug 27, 2020

@ekohl done

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Since this diff could be hard to read, it was enough to add 2x if $ensure == 'present' and 1x exec { "gluster stop and remove ${title}": :)

Git and Github also have options to hide whitespace changes. They showed the same thing.

@ekohl ekohl merged commit ae43a34 into voxpupuli:master Aug 28, 2020
@ekohl ekohl mentioned this pull request Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants