Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comparison when ordering in facts and settings is different #256

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VictorPavlushin
Copy link

Pull Request (PR) description

If the sequence in facts and settings is different exampe:
[ 'gst02:/opt/share', 'gst03:/opt/share', 'gst01:/opt/share'] != [ 'gst01:/opt/share', 'gst02:/opt/share', 'gst03:/opt/share']
but in fact they are equal

This Pull Request (PR) fixes the following issues

If the sequence in facts and settings is different
exampe:
[ 'gst02:/opt/share', 'gst03:/opt/share', 'gst01:/opt/share'] !=
[ 'gst01:/opt/share', 'gst02:/opt/share', 'gst03:/opt/share']
but in fact they are equal
@smortex smortex changed the title If the sequence in facts and settings is different Fix comparison when the sequence in facts and settings is different Dec 29, 2023
@smortex smortex changed the title Fix comparison when the sequence in facts and settings is different Fix comparison when ordering in facts and settings is different Dec 29, 2023
@smortex smortex added the bug Something isn't working label Dec 29, 2023
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a non-gluster-user perspective, this looks fine. Can another reviewer have a look and merge if it makes sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants