Handle failures from gluster volume status foo
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gluster can, on occasion, not release some locks that cause various `gluster` commands to fail. The custom fact in this module would choke on these failures, which in turn would prevent Puppet from executing. There are still improvements to be made to error catching, but these changes should at least let Puppet runs keep going, even if Gluster does have stale locks.
|
Looks good, aside from the indenting you mentioned. I guess that's just using spaces vs. tabs. |
The real change of this pull request remains at line 44-49, where we catch failures from the `gluster volume status` command for each volume. This commit simply tidies up the tabs and whitespace.
skpy
added a commit
that referenced
this pull request
Jan 19, 2015
Handle failures from `gluster volume status foo`. Also using `set tabstop=2` and `set shiftwidth=2` in my .vimrc, so indentation has changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gluster can, on occasion, not release some locks that cause various
glustercommands to fail. The custom fact in this module would chokeon these failures, which in turn would prevent Puppet from executing.
There are still improvements to be made to error catching, but these
changes should at least let Puppet runs keep going, even if Gluster does
have stale locks.